iCal Event removal/edit on subscription refresh/update

[liveaverage]

PHP: PHP Version 5.2.3-1ubuntu6.3
Joomla: Version 1.5.8
JEvents: 1.5alpha3
Web Server: Server version: Apache/2.2.4 (Ubuntu)
Server OS: Ubuntu 6.06 LTS
MySQL: Server version: 5.0.45-Debian_1ubuntu3.1-log
memory_limit: 128MB

Just had a quick inquiry:

Should the current alpha release or SVN1281 support the removal of iCal subscription entries that have been removed on the source calendar(s)? If not, is there anywhere I could/should start looking to help add this functionality? Thanks for all your help!

>JR

[Geraint]

From memory when you do a refresh the code removes all entries from the imported calendar and gets a fresh copy so all changes and deletions should be respected.

It should also respect exceptions (i.e. individual repeats that are deleted or changed)

Geraint

[liveaverage]

Man, I'm always impressed with your quick replies! Don't know how you manage staying up with everything If it's not updating/deleting iCal entries from the URL subscription (for some reason it isn't), is it recommended to uninstall/reinstall the component and see if that helps? I'll go ahead and try (+ post back). If that doesn't solve it, would you have any other recommendations for tracing the problem? Thanks for the time + answer.

EDIT: from /administrator/components/com_jevents/controllers/icals.php

Starting @ Line 275:

Code: Select all

               // Note for refresh of re-import I could clear out the existing values in case one or
                        // more events in the file have gone - but this plays havoc with Joomfish !!!

                        // TODO trap deleted events and remove them after the reload
                        // Should come from the form or existing item
                        $state = 1;
                        if (strlen($currentICS->srcURL)==0) {
                                echo "Can only reload URL based subscriptions";
                                return;
                        }
                        $uploadURL = $currentICS->srcURL;

On the 'TODO' item, is this comment now obsolete, or has this not been implemented yet?

[Geraint]

OK - I've added an extra layer in the import. We check all existing events in the calendar and if any are not 'updated' they are removed.

Geraint

[liveaverage]

Geraint, I really appreciate this ((quick and effective)) fix! It's working great. I'm not sure it's related or not, but I was getting an error thrown on line 24 of :

components/com_jevents/libraries/modfunctions.php Warning: Invalid argument supplied for foreach()

I've commented the code out (since my modules are public view only), but I'll look into fixing this myself as well. I'll post any fixes or finds I come up with. Thanks for all of your assistance!!

>JR

[Geraint]

You need a menu item pointing at JEvents (even if its not on a visible menu).

Geraint