Conflicts with other modules - Solved turn error mode off

[PTRyan]

Alpha 3 has conflicts with several other module extensions. I have what appear to be java conflicts with CustomFooter; MSComment; and AccordionMenu.

I've got Joomla! 1.5.9 and Alpha 3 Build 1284 right off of the SVN.

The errors are typically undefined variables such as
"Notice: Undefined variable: image in /home2/nkllcom/public_html/joomla/modules/mod_accordionmenu/helper.php on line 312";
or "Notice: Undefined property: stdClass::$id in /home2/nkllcom/public_html/joomla/plugins/content/msComment.php on line 37";
or "Notice: Undefined variable: part3 in /home2/nkllcom/public_html/joomla/modules/mod_customFooter/helper.php on line 28"

These errors were not in Alpha 2.

Pat Ryan

[Geraint]

I can understand the possibility of a poorly constructed plugin failing but not a module.

Can you copy the 10 lines of code around the referenced lines and paste them in "code" tags in your reply?

[PTRyan]

Geraint,

Thanks for the reply.

Here is a code snip from AccordianMenu

Code: Select all

      // Print a link if it exists
      if ($tmp->url != null)
      {
         // Handle SSL links
         $iParams = new JParameter($tmp->params);
         $iSecure = $iParams->def('secure', 0);
         if ($tmp->home == 1) {
            $tmp->url = JURI::base();
         } elseif (strcasecmp(substr($tmp->url, 0, 4), 'http') && (strpos($tmp->link, 'index.php?') !== false)) {
            $tmp->url = JRoute::_($tmp->url, true, $iSecure);
         } else {
            $tmp->url = str_replace('&', '&', $tmp->url);
         }

         switch ($tmp->browserNav)
         {
            default:
            case 0:
               // _top
//Next Line is what pops the error - Pat Ryan 2-3-09
               $data = '<a href="'.$tmp->url.'">'.$image.$tmp->name.'</a>';
               break;
            case 1:
               // _blank
               $data = '<a href="'.$tmp->url.'" target="_blank">'.$image.$tmp->name.'</a>';
               break;
            case 2:
               // window.open
               $attribs = 'toolbar=no,location=no,status=no,menubar=no,scrollbars=yes,resizable=yes,'.$this->_params->get('window_open');

               // hrm...this is a bit dickey
               $link = str_replace('index.php', 'index2.php', $tmp->url);
               $data = '<a href="'.$link.'" onclick="window.open(this.href,\'targetWindow\',\''.$attribs.'\');return false;">'.$image.$tmp->name.'</a>';
               break;
         }
      } else {
         $data = '<a>'.$image.$tmp->name.'</a>';
      }


=======================================

Here is a snip from the plugin for MSComment. Note that the $query calls all generate the error.

Code: Select all

class plgContentmsComment extends JPlugin
{
   function plgContentmsComment(&$subject)//, $config)
   {
      parent::__construct($subject, "");
   }
   
   function onPrepareContent(& $article, & $params, $page = 0)
   {
      global $mainframe;
      
      $db = & JFactory::getDBO();
      $document = &JFactory::getDocument();
      $jsPath = '/plugins/content/JavaScript/msComment.js';
      $document->addScript(JURI::root(true) . $jsPath);
      $css = JURI::root(true) . "/administrator/components/com_mscomment/msComment.css";
      $document->addStyleSheet($css);
      
      
      // Check if comments disabled for this article.
      $enabled = true;
      // Check Article
// The $query lines all generate errors - Pat Ryan 2-3-09
      $query = "SELECT id from " . $db->nameQuote('#__msComment_Disabled') . " WHERE " . $db->nameQuote('target_id') . " = " . $article->id . " AND " . $db->nameQuote('type') . " = 'article'";
      $db->setQuery($query);
      $found = $db->loadResult();
      if ($found) $enabled = false;
      // Check Category
      $query = "SELECT id from " . $db->nameQuote('#__msComment_Disabled') . " WHERE " . $db->nameQuote('target_id') . " = " . $article->catid . " AND " . $db->nameQuote('type') . " = 'category'";
      $db->setQuery($query);
      $found = $db->loadResult();
      if ($found) $enabled = false;


=======================================

For customFooter I got it to work if I preset the variables to a blank string first otherwise $customFooter = $part1.$part2.$part3.$part4.$part5; generates the error. Here is the entire helper.php module.

Code: Select all

<?php
// no direct access
defined('_JEXEC') or die('Restricted access');

require_once (JPATH_SITE.DS.'components'.DS.'com_content'.DS.'helpers'.DS.'route.php');

class modCustomFooter
{
   function getFooterCode($sitenameToDisplay,$footerSeparatorToDisplay,$footerTextLine1ToDisplay,$footerTextLine1HtmlEncodeCheck,$footerTextLine2ToDisplay,$footerTextLine2HtmlEncodeCheck,$footerTextCharset)
   {
      $part1 = "Copyright &#169; ".date("Y");
// The following 4 lines were added and that stopped the error - Pat Ryan 2-3-09
      $part2 = "";
      $part3 = "";
      $part4 = "";
      $part5 = "";
      if ($sitenameToDisplay != "")
      {
         $part2 = " ".htmlentities($sitenameToDisplay,ENT_QUOTES,$footerTextCharset);
      }
      if ($footerSeparatorToDisplay != "")
      {
         $part3 = " ".htmlentities($footerSeparatorToDisplay,ENT_QUOTES,$footerTextCharset);
      }
      if ($footerTextLine1ToDisplay != "")
      {
         if ($footerTextLine1HtmlEncodeCheck == "1")
         {
            $part4 = " ".html_entity_decode($footerTextLine1ToDisplay,ENT_QUOTES,$footerTextCharset);
         }
         elseif ($footerTextLine1HtmlEncodeCheck == "2")
         {
            $part4 = " ".htmlentities($footerTextLine1ToDisplay,ENT_QUOTES,$footerTextCharset);
         }
         else
         {
            $part4 = "";
         }
      }
      if ($footerTextLine2ToDisplay != "")
      {
         if ($footerTextLine2HtmlEncodeCheck == "1")
         {
            $part5 = "<br />".html_entity_decode($footerTextLine2ToDisplay,ENT_QUOTES,$footerTextCharset);
         }
         elseif ($footerTextLine2HtmlEncodeCheck == "2")
         {
            $part5 = "<br />".htmlentities($footerTextLine2ToDisplay,ENT_QUOTES,$footerTextCharset);
         }
         else
         {
            $part5 = "";
         }
      }
// The next line generated the error - Pat Ryan 2-3-09
      $customFooter = $part1.$part2.$part3.$part4.$part5;
      echo($customFooter);
   }
}


Thanks for your help.

Note that these errors did not happen with Alpha2.

php 5.2.8

[Geraint]

These are not clashes but bugs in these components/plugins - its just that I switch on error reporting in the alpha 3 code.

comment out line 9 of components/com_jevents/jevents.php

Geraint

[PTRyan]

Geraint,

That was too easy!

I'll follow up with the "offending" modules with their authors.

Thanks.